Changeset 454

Timestamp:

05/17/11 22:29:59 (2 years ago)

Author:

tadamusiak

Message:

fix for the object properties URIs

Location:

trunk/ontoCAT/src/uk/ac/ebi/ontocat/file

Files:

• FixBrokenObjectPropertiesIRIStrategy.java (deleted)
• ReasonedFileOntologyService.java (modified) (2 diffs)

trunk/ontoCAT/src/uk/ac/ebi/ontocat/file/ReasonedFileOntologyService.java

@@ -23 +23 @@
 import org.semanticweb.owlapi.model.OWLObjectProperty;
 import org.semanticweb.owlapi.model.OWLObjectPropertyExpression;
-import org.semanticweb.owlapi.model.OWLOntology;
 import org.semanticweb.owlapi.reasoner.OWLReasoner;
 import org.semanticweb.owlapi.reasoner.OWLReasonerFactory;
-import org.semanticweb.owlapi.util.OWLEntityURIConverter;
 
 import uk.ac.ebi.ontocat.OntologyService;
@@ -97 +95 @@
         }
 
-        // FIXME: Apply the URI conversion strategy to fix
-        // the OWL API 3.2.2 object property issue
-        // this fixes the uris and merges the duplicated
-        // object properties
+        // FIXME: fix for OWL API 3.2.2 object property bug
+        // which duplicates object properties by introducing
+        // incorrect URIs in OBOConsumer
+        // this goes through all the properties and removes
+        // the ones that are not used anywhere (duplicates)
         private void fixPropertiesURIs() {
-                Set<OWLOntology> ontologies = new HashSet<OWLOntology>();
-                ontologies.add(ontology);
-                OWLEntityURIConverter converter = new OWLEntityURIConverter(
-                                loader.getManager(), ontologies,
-                                new FixBrokenObjectPropertiesIRIStrategy());
-                loader.getManager().applyChanges(converter.getChanges());
+                for (OWLObjectProperty prop : ontology.getObjectPropertiesInSignature()) {
+                        if (prop.getReferencingAxioms(ontology).size() == 1) {
+                                loader.getManager().removeAxiom(
+                                                ontology,
+                                                loader.getManager().getOWLDataFactory()
+                                                .getOWLDeclarationAxiom(prop));
+                        }
+                }
         }